svcd_ndispatch #32
svcd_ndispatch #32
Conversation
Merge branch 'master' of https://github.com/UCB-IoET/personal-nikita
|
TEAM BIRDPEOPLE |
| sprintf(ivkidstr, "%d", ivkid); | ||
| lua_pushstring(L, ivkidstr); | ||
| lua_gettable(L, 6); | ||
|
|
There was a problem hiding this comment.
We think it might be clearer to -1 instead of 6 here.
Holy Cow
Edit: It should be -2 not -1.
There was a problem hiding this comment.
I agree, and maybe do the same in line 210 by replacing 5 with -1.
-PB4J
Edit: Shouldn't it be -2, since -1 refers to the top of the stack?
There was a problem hiding this comment.
I'd say either way works. this numbering scheme seems to step up - you can see the stack grow from 5 to 7 elements, and no items are popped from the stack so it's pretty simple.
If you do renumber it to -1, then I'd definitely suggest doing so for the rest of the stack indices, for consistency.
Fantastic Four
|
This looks good, but it seems like you have included unnecessary files which probably should be removed. |
| //Override symbols in the lua table with C implementation | ||
| lua_pushstring(L, "ndispatch"); | ||
| lua_pushlightfunction(L, svcd_ndispatch); | ||
| lua_settable(L, 3); | ||
|
|
There was a problem hiding this comment.
I don't think that you need to override with the C function here.
Holy Cow
There was a problem hiding this comment.
Yeah, is there a reason for the override symbols?
There was a problem hiding this comment.
I put it there in order to get it to run the C version
|
why is ikvid indexed as -1? it seems like that should be srcport |
|
You can pull request only the svcd.c file by doing a cherrypick of the relevant commits, or more simply make a fresh branch off of the original master and copy the new svcd.c and pull request that. and submit a pull request from the new branch |
| uint16_t ivkid = lua_tonumber(L, -1); // changes pay parameter to number and returns | ||
| lua_getglobal(L, "SVCD"); // gets table | ||
| lua_pushstring(L, "oursubs"); // use oursubs as the key | ||
| lua_gettable(L, 5); |
There was a problem hiding this comment.
lua_gettable is expects the index of the table to be provided as an argument, and pops the key from the top of the stack. Unless I'm mistaken the table is at index 4 and the key is at index 5. So to get SVCD.oursubs, you'd do lua_gettable(L, 4), which would pop "oursubs" from the stack and then push SVCD.oursubs (which you want) to the top.
-men in #000000
| const char* item = lua_tolstring(L, 6, &size); | ||
| if (!lua_isnil(L, 7)) { | ||
| char newstr[3]; | ||
| strncpy(newstr, pay, 3); |
There was a problem hiding this comment.
char * strncpy ( char * destination, const char * source, size_t num ); copies the first num characters from source to destination.
string.sub (s, i [, j]) returns the substring of s from the i-th character to the j-th character. If j is missing, it will return from the i-th character to the end of the string.
After line 220, your [newstr] is the first 3 characters of the string [pay]. However, in the original code, it requires all characters of [pay] from 3rd and forward. This may cause some problem.
Untitled
|
This has been superceded by #40 |
No description provided.